{-# LANGUAGE OverloadedStrings #-} {-# LANGUAGE Strict #-} module Tokstyle.Linter.CallbackNames (descr) where import Control.Monad (unless) import Control.Monad.State.Strict (State) import qualified Control.Monad.State.Strict as State import Data.Fix (Fix (..)) import Data.Text (Text) import qualified Data.Text as Text import Language.Cimple (Lexeme (..), Node, NodeF (..)) import Language.Cimple.Diagnostics (CimplePos, Diagnostic) import Language.Cimple.TraverseAst (AstActions, astActions, doNode, traverseAst) import Prettyprinter (pretty, (<+>)) import Tokstyle.Common (backticks, warn, warnDoc) allowed :: [Text] allowed :: [Text] allowed = [Text "callback" , Text "cb" , Text "function" , Text "handler" ] isValid :: Text -> Bool isValid :: Text -> Bool isValid Text name = (Text -> Bool) -> [Text] -> Bool forall (t :: * -> *) a. Foldable t => (a -> Bool) -> t a -> Bool any (Text -> Text -> Bool `Text.isSuffixOf` Text name) [Text] allowed linter :: AstActions (State [Diagnostic CimplePos]) Text linter :: AstActions (State [Diagnostic CimplePos]) Text linter = AstActions (State [Diagnostic CimplePos]) Text forall (f :: * -> *) text. Applicative f => AstActions f text astActions { doNode :: FilePath -> Node (Lexeme Text) -> State [Diagnostic CimplePos] () -> State [Diagnostic CimplePos] () doNode = \FilePath file Node (Lexeme Text) node State [Diagnostic CimplePos] () act -> case Node (Lexeme Text) -> NodeF (Lexeme Text) (Node (Lexeme Text)) forall (f :: * -> *). Fix f -> f (Fix f) unFix Node (Lexeme Text) node of VarDecl (Fix (TyPointer (Fix TyFunc{}))) (L AlexPosn _ LexemeClass _ Text varName) [Node (Lexeme Text)] _ -> Bool -> State [Diagnostic CimplePos] () -> State [Diagnostic CimplePos] () forall (f :: * -> *). Applicative f => Bool -> f () -> f () unless (Text -> Bool isValid Text varName) (State [Diagnostic CimplePos] () -> State [Diagnostic CimplePos] ()) -> State [Diagnostic CimplePos] () -> State [Diagnostic CimplePos] () forall a b. (a -> b) -> a -> b $ FilePath -> Node (Lexeme Text) -> Doc AnsiStyle -> State [Diagnostic CimplePos] () forall diags at. (HasDiagnosticsRich diags CimplePos, HasDiagnosticInfo at CimplePos) => FilePath -> at -> Doc AnsiStyle -> DiagnosticsT diags () warnDoc FilePath file Node (Lexeme Text) node (Doc AnsiStyle -> State [Diagnostic CimplePos] ()) -> Doc AnsiStyle -> State [Diagnostic CimplePos] () forall a b. (a -> b) -> a -> b $ Doc AnsiStyle "function pointer" Doc AnsiStyle -> Doc AnsiStyle -> Doc AnsiStyle forall ann. Doc ann -> Doc ann -> Doc ann <+> Doc AnsiStyle -> Doc AnsiStyle forall ann. Doc ann -> Doc ann backticks (Text -> Doc AnsiStyle forall a ann. Pretty a => a -> Doc ann pretty Text varName) Doc AnsiStyle -> Doc AnsiStyle -> Doc AnsiStyle forall ann. Doc ann -> Doc ann -> Doc ann <+> Doc AnsiStyle "should end in `callback`" VarDecl (Fix TyFunc{}) (L AlexPosn _ LexemeClass _ Text varName) [Node (Lexeme Text)] _ -> Bool -> State [Diagnostic CimplePos] () -> State [Diagnostic CimplePos] () forall (f :: * -> *). Applicative f => Bool -> f () -> f () unless (Text -> Bool isValid Text varName) (State [Diagnostic CimplePos] () -> State [Diagnostic CimplePos] ()) -> State [Diagnostic CimplePos] () -> State [Diagnostic CimplePos] () forall a b. (a -> b) -> a -> b $ FilePath -> Node (Lexeme Text) -> Doc AnsiStyle -> State [Diagnostic CimplePos] () forall diags at. (HasDiagnosticsRich diags CimplePos, HasDiagnosticInfo at CimplePos) => FilePath -> at -> Doc AnsiStyle -> DiagnosticsT diags () warnDoc FilePath file Node (Lexeme Text) node (Doc AnsiStyle -> State [Diagnostic CimplePos] ()) -> Doc AnsiStyle -> State [Diagnostic CimplePos] () forall a b. (a -> b) -> a -> b $ Doc AnsiStyle "function pointer parameter" Doc AnsiStyle -> Doc AnsiStyle -> Doc AnsiStyle forall ann. Doc ann -> Doc ann -> Doc ann <+> Doc AnsiStyle -> Doc AnsiStyle forall ann. Doc ann -> Doc ann backticks (Text -> Doc AnsiStyle forall a ann. Pretty a => a -> Doc ann pretty Text varName) Doc AnsiStyle -> Doc AnsiStyle -> Doc AnsiStyle forall ann. Doc ann -> Doc ann -> Doc ann <+> Doc AnsiStyle "should end in `callback`" NodeF (Lexeme Text) (Node (Lexeme Text)) _ -> State [Diagnostic CimplePos] () act } analyse :: (FilePath, [Node (Lexeme Text)]) -> [Diagnostic CimplePos] analyse :: (FilePath, [Node (Lexeme Text)]) -> [Diagnostic CimplePos] analyse = [Diagnostic CimplePos] -> [Diagnostic CimplePos] forall a. [a] -> [a] reverse ([Diagnostic CimplePos] -> [Diagnostic CimplePos]) -> ((FilePath, [Node (Lexeme Text)]) -> [Diagnostic CimplePos]) -> (FilePath, [Node (Lexeme Text)]) -> [Diagnostic CimplePos] forall b c a. (b -> c) -> (a -> b) -> a -> c . (State [Diagnostic CimplePos] () -> [Diagnostic CimplePos] -> [Diagnostic CimplePos]) -> [Diagnostic CimplePos] -> State [Diagnostic CimplePos] () -> [Diagnostic CimplePos] forall a b c. (a -> b -> c) -> b -> a -> c flip State [Diagnostic CimplePos] () -> [Diagnostic CimplePos] -> [Diagnostic CimplePos] forall s a. State s a -> s -> s State.execState [] (State [Diagnostic CimplePos] () -> [Diagnostic CimplePos]) -> ((FilePath, [Node (Lexeme Text)]) -> State [Diagnostic CimplePos] ()) -> (FilePath, [Node (Lexeme Text)]) -> [Diagnostic CimplePos] forall b c a. (b -> c) -> (a -> b) -> a -> c . AstActions (State [Diagnostic CimplePos]) Text -> (FilePath, [Node (Lexeme Text)]) -> State [Diagnostic CimplePos] () forall text a (f :: * -> *). (TraverseAst text a, Applicative f) => AstActions f text -> a -> f () traverseAst AstActions (State [Diagnostic CimplePos]) Text linter descr :: ((FilePath, [Node (Lexeme Text)]) -> [Diagnostic CimplePos], (Text, Text)) descr :: ((FilePath, [Node (Lexeme Text)]) -> [Diagnostic CimplePos], (Text, Text)) descr = ((FilePath, [Node (Lexeme Text)]) -> [Diagnostic CimplePos] analyse, (Text "callback-names", [Text] -> Text Text.unlines [Text "Checks for naming conventions for callbacks. Callback names should end in" , Text "`callback`, but the following list of suffixes is permitted:" , Text "" , Text -> [Text] -> Text Text.intercalate Text "\n" ([Text] -> Text) -> ([Text] -> [Text]) -> [Text] -> Text forall b c a. (b -> c) -> (a -> b) -> a -> c . (Text -> Text) -> [Text] -> [Text] forall a b. (a -> b) -> [a] -> [b] map (\Text x -> Text "- `" Text -> Text -> Text forall a. Semigroup a => a -> a -> a <> Text x Text -> Text -> Text forall a. Semigroup a => a -> a -> a <> Text "`") ([Text] -> Text) -> [Text] -> Text forall a b. (a -> b) -> a -> b $ [Text] allowed , Text "" , Text "**Reason:** naming conventions help quickly understand the code." ]))